Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comment thread with first comment deleted #4680

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

gbalint
Copy link
Contributor

@gbalint gbalint commented Jan 3, 2024

Problem:
When the first comment of a thread is deleted, the comment text in the right sidebar and in the hovered comment marker is empty.

Fix:
The problem is that the deleted comment still exists in thread.comments, it just receives a deletedAt flag.
This means we can not find the first non-deleted comment in comments[0].
I implemented a helper called getFirstComment instead of just using comments[0].

Copy link
Contributor

github-actions bot commented Jan 3, 2024

Try me

Copy link

relativeci bot commented Jan 3, 2024

Job #9683: Bundle Size — 62.18MiB (~+0.01%).

69fa020(current) vs df0030c master#9679(baseline)

Warning

Bundle contains 66 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change Regression 1 regression
                 Current
Job #9683
     Baseline
Job #9679
Regression  Initial JS 45.39MiB(~+0.01%) 45.39MiB
No change  Initial CSS 0B 0B
No change  Cache Invalidation 19.85% 19.85%
No change  Chunks 26 26
No change  Assets 30 30
No change  Modules 4361 4361
No change  Duplicate Modules 470 470
No change  Duplicate Code 30.75% 30.75%
No change  Packages 462 462
No change  Duplicate Packages 65 65
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #9683
     Baseline
Job #9679
Regression  JS 62.17MiB (~+0.01%) 62.17MiB
Not changed  HTML 11.53KiB 11.53KiB

View job #9683 reportView fix/deleted-first-comment branch activity

Copy link
Contributor

github-actions bot commented Jan 3, 2024

Performance test results:
(Chart1)
(Chart2)

@gbalint gbalint merged commit f8c8b50 into master Jan 3, 2024
12 checks passed
@gbalint gbalint deleted the fix/deleted-first-comment branch January 3, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants