Fix comment thread with first comment deleted #4680
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When the first comment of a thread is deleted, the comment text in the right sidebar and in the hovered comment marker is empty.
Fix:
The problem is that the deleted comment still exists in
thread.comments
, it just receives adeletedAt
flag.This means we can not find the first non-deleted comment in
comments[0]
.I implemented a helper called
getFirstComment
instead of just usingcomments[0]
.