Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show resolved comment indicators #4677

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Show resolved comment indicators #4677

merged 2 commits into from
Jan 3, 2024

Conversation

bkrmendy
Copy link
Contributor

@bkrmendy bkrmendy commented Jan 3, 2024

Problem

We don't show comment indicators for resolved threads even if the Show resolved thread is clicked in the comment sidebar

Fix

Remove the check for resolved status in CommentIndicatorUI

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2024 •
edited
Loading

Try me

@relativeci RelativeCI
Copy link

relativeci bot commented Jan 3, 2024

Job #9674: Bundle Size — 62.18MiB (~-0.01%).

5ada1a3(current) vs df0030c master#9673(baseline)

Warning

Bundle contains 66 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change Improvement 1 improvement
                 Current
Job #9674		      Baseline
Job #9673
Improvement  Initial JS 45.39MiB(~-0.01%) 45.39MiB
No change  Initial CSS 0B 0B
No change  Cache Invalidation 19.85% 19.85%
No change  Chunks 26 26
No change  Assets 30 30
No change  Modules 4361 4361
No change  Duplicate Modules 470 470
No change  Duplicate Code 30.75% 30.75%
No change  Packages 462 462
No change  Duplicate Packages 65 65
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
Job #9674		      Baseline
Job #9673
Improvement  JS 62.17MiB (~-0.01%) 62.17MiB
Not changed  HTML 11.53KiB 11.53KiB

View job #9674 report View fix/show-resolved-comment-indica... branch activity

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2024

Performance test results:
(Chart1)
(Chart2)

@bkrmendy bkrmendy merged commit d7c59a6 into master Jan 3, 2024
12 checks passed
@bkrmendy bkrmendy deleted the fix/show-resolved-comment-indicators branch January 3, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanparsons seanparsons seanparsons approved these changes

@gbalint gbalint gbalint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bkrmendy @gbalint @seanparsons