Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close thread preview on resolve #4674

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Close thread preview on resolve #4674

merged 1 commit into from
Jan 2, 2024

Conversation

bkrmendy
Copy link
Contributor

@bkrmendy bkrmendy commented Jan 2, 2024

Problem

We show the thread preview even after the corresponding thread has been resolved

Fix

Close the thread preview when the thread has been resolved

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2024 •
edited
Loading

Try me

@relativeci RelativeCI
Copy link

relativeci bot commented Jan 2, 2024

Job #9664: Bundle Size — 62.14MiB (~+0.01%).

df99062(current) vs df0030c master#9654(baseline)

Warning

Bundle contains 66 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #9664		      Baseline
Job #9654
Regression  Initial JS 45.35MiB(~+0.01%) 45.35MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 19.79% 0%
No change  Chunks 26 26
No change  Assets 30 30
No change  Modules 4359 4359
No change  Duplicate Modules 468 468
No change  Duplicate Code 30.72% 30.72%
No change  Packages 462 462
No change  Duplicate Packages 65 65
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #9664		      Baseline
Job #9654
Regression  JS 62.13MiB (~+0.01%) 62.13MiB
Not changed  HTML 11.53KiB 11.53KiB

View job #9664 report View fix/close-thread-on-resolve branch activity

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2024

Performance test results:
(Chart1)
(Chart2)

@bkrmendy bkrmendy merged commit 0fe6529 into master Jan 2, 2024
12 checks passed
@bkrmendy bkrmendy deleted the fix/close-thread-on-resolve branch January 2, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rheeseyb Rheeseyb Rheeseyb approved these changes

@gbalint gbalint gbalint approved these changes

@seanparsons seanparsons Awaiting requested review from seanparsons

@ruggi ruggi Awaiting requested review from ruggi

@balazsbajorics balazsbajorics Awaiting requested review from balazsbajorics

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bkrmendy @gbalint @Rheeseyb