Highlight target scene of comment #4597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkrmendy
reviewed
Dec 4, 2023
| if (remixState == null) { | ||
| return | ||
| } | ||
| remixState.navigate(remixLocationRoute) | ||
| }) | ||
| } | ||
| dispatch([ | ||
|
|
||
| const actions = stripNulls([ |
There was a problem hiding this comment.
can you use openCommentThreadActions?
There was a problem hiding this comment.
True, that is why i extracted these to openCommentThreadActions, thanks!
bkrmendy
approved these changes
Dec 4, 2023
Job #9444: Bundle Size — 66.34MiB (~+0.01%).
Warning Bundle contains 68 duplicate packages – View duplicate packages Bundle metrics
 
Bundle size by type
View job #9444 report View feature/highlight-comment-scene branch activity |
|
Performance test results: |
ruggi
approved these changes
Dec 4, 2023
| @@ -98,18 +99,22 @@ const CommentIndicator = React.memo(({ thread }: CommentIndicatorProps) => { | |||
| const onClick = React.useCallback(() => { | |||
| if (isOnAnotherRoute && remixLocationRoute != null) { | |||
| // TODO: after we have scene identifier in the comment metadata we should only navigate the scene with the comment | |||
| Object.keys(remixNavigationState).forEach((scene) => { | |||
| const remixState = remixNavigationState[scene] | |||
| Object.keys(remixNavigationState).forEach((s) => { | |||
There was a problem hiding this comment.
wasn't it better the way it was before?
There was a problem hiding this comment.
I renamed it because i have a variable named scene in the outer scope. But I renamed that now, and renamed this inner s to scene again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: