Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loading YJS doc/provider #4549

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Fix loading YJS doc/provider #4549

merged 1 commit into from
Nov 22, 2023

Conversation

ruggi
Copy link
Contributor

@ruggi ruggi commented Nov 22, 2023

Fix #4548

The YJS loading can break and enter an endless loop of connecting and disconnecting, due to the doc being destroyed (but not recreated) and when the room is not ready for consumption yet.

This PR fixes it.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 22, 2023 •
edited
Loading

Try me

@relativeci RelativeCI
Copy link

relativeci bot commented Nov 22, 2023

Job #9316: Bundle Size — 65.88MiB (~+0.01%).

c59bc80(current) vs 5957b21 master#9310(baseline)

Warning

Bundle contains 67 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #9316		      Baseline
Job #9310
Regression  Initial JS 48.03MiB(~+0.01%) 48.03MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 18.31% 0%
No change  Chunks 25 25
No change  Assets 29 29
No change  Modules 4431 4431
No change  Duplicate Modules 475 475
No change  Duplicate Code 30.43% 30.43%
No change  Packages 458 458
No change  Duplicate Packages 67 67
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #9316		      Baseline
Job #9310
Regression  JS 65.87MiB (~+0.01%) 65.87MiB
Not changed  HTML 11.32KiB 11.32KiB

View job #9316 report View fix/room-ydoc-load branch activity

@github-actions GitHub Actions
Copy link
Contributor

Performance test results:
(Chart1)
(Chart2)

@ruggi ruggi merged commit ec0135c into master Nov 22, 2023
12 checks passed
@ruggi ruggi deleted the fix/room-ydoc-load branch November 22, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balazsbajorics balazsbajorics balazsbajorics approved these changes

@Rheeseyb Rheeseyb Rheeseyb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix yjs loading
3 participants
@ruggi @Rheeseyb @balazsbajorics