Avoid follow mode loops #4515
Merged
Avoid follow mode loops #4515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Job #9244: Bundle Size — 65.58MiB (~+0.01%).
Warning Bundle contains 67 duplicate packages – View duplicate packages Bundle metrics
 
Bundle size by type
View job #9244 report View feat/avoid-loop-follow branch activity |
Rheeseyb
reviewed
Nov 20, 2023
|
Performance test results: |
# Conflicts: # editor/liveblocks.config.ts # editor/src/components/canvas/multiplayer-cursors.tsx # editor/src/components/user-bar.tsx # editor/src/core/shared/multiplayer.ts
balazsbajorics
approved these changes
Nov 21, 2023
gbalint
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4514
Problem:
It should not be possible to have follow mode loops that would lock the editor for all players (e.g.
a→b→c→a).Fix:
Prevent those loops when turning follow mode on.