-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate AWS SDK for JavaScript v2 APIs to v3 #4488
base: master
Are you sure you want to change the base?
Conversation
Hey @trivikr thanks for opening this PR. This appears to be missing the |
That's a bug (unnecessary keys) in existing code. Those values are just ignored, and the JS SDK (both v2 and v3) automatically reads credentials. |
This reverts commit 33c7e63.
4fe2b5e
to
6001959
Compare
6001959
to
47e2f29
Compare
I've rebase changes from last three months in the PR. Is there anything else needed for review/merge? cc @Rheeseyb |
AWS SDK for JavaScript v2 will enter maintenance mode on September 8, 2024 and reach end-of-support on September 8, 2025. For more information, check blog post at https://a.co/cUPnyil |
Problem:
From AWS SDK for JavaScript v2 README:
Fix:
This PR migrates AWS SDK for JavaScript v2 APIs to v3 using aws-sdk-js-codemod.
$ npx [email protected] -t v2-to-v3 puppeteer-tests/src/**/*.ts