Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate AWS SDK for JavaScript v2 APIs to v3 #4488

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

trivikr
Copy link

@trivikr trivikr commented Nov 15, 2023

Problem:

From AWS SDK for JavaScript v2 README:

We are formalizing our plans to make the Maintenance Announcement (Phase 2) for AWS SDK for JavaScript v2 in 2023.

Fix:

This PR migrates AWS SDK for JavaScript v2 APIs to v3 using aws-sdk-js-codemod.

$ npx [email protected] -t v2-to-v3 puppeteer-tests/src/**/*.ts

@trivikr trivikr marked this pull request as ready for review November 15, 2023 03:59
@Rheeseyb
Copy link
Contributor

Hey @trivikr thanks for opening this PR. This appears to be missing the AWS_SECRET_ACCESS_KEY and AWS_ACCESS_KEY_ID. Please can you add those in, and then we can test it out.

@trivikr
Copy link
Author

trivikr commented Nov 15, 2023

This appears to be missing the AWS_SECRET_ACCESS_KEY and AWS_ACCESS_KEY_ID

That's a bug (unnecessary keys) in existing code.
The AWS Config in v2 does not have AWS_SECRET_ACCESS_KEY and AWS_ACCESS_KEY_ID.

Those values are just ignored, and the JS SDK (both v2 and v3) automatically reads credentials.

@trivikr trivikr force-pushed the aws-sdk-js-codemod branch 2 times, most recently from 4fe2b5e to 6001959 Compare February 19, 2024 17:00
@trivikr
Copy link
Author

trivikr commented Feb 19, 2024

I've rebase changes from last three months in the PR. Is there anything else needed for review/merge?

cc @Rheeseyb

@trivikr
Copy link
Author

trivikr commented Mar 11, 2024

AWS SDK for JavaScript v2 will enter maintenance mode on September 8, 2024 and reach end-of-support on September 8, 2025.

For more information, check blog post at https://a.co/cUPnyil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants