Don't select invisible portions of truncated elements during draw-to-select #4393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balazsbajorics
approved these changes
Oct 18, 2023
bkrmendy
approved these changes
Oct 18, 2023
Job #8761: Bundle Size — 63.64MiB (~+0.01%).
Warning Bundle contains 64 duplicate packages – View duplicate packages Bundle metrics
 
Bundle size by type
View job #8761 report View fix/selection-area-overflow-hidd... branch activity |
Rheeseyb
approved these changes
Oct 18, 2023
|
Performance test results: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4391
Problem:
Truncated elements have their measurements calculated incorrectly (known issue), which means they can be interacted with when the mouse is over their invisible (truncated) portions. This means that draw-to-select is broken as well.
Fix:
This is purely a mitigation of the underlying issue, that omits those elements from the draw-to-select targets when their invisible portions are selected.
Again, this does not solve the problem, but excluding those portions from the draw-to-select reduces the impact of the problem while we figure out how to solve the measurements altogether.