Fill out layoutSystemForChildren in fixSpyOnlyMetadata
#4374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Job #8685: Bundle Size — 63.28MiB (~+0.01%).
Warning Bundle contains 64 duplicate packages – View duplicate packages Bundle metrics
 
Bundle size by type
View job #8685 report View fix/conditionals-layout-system-f... branch activity |
bkrmendy
requested review from
gbalint,
ruggi,
seanparsons,
balazsbajorics and
Rheeseyb
|
Performance test results: |
bkrmendy
changed the title
layoutSystemForChildren for conditionalslayoutSystemForChildren in fixSpyOnlyMetadata
editor/src/components/canvas/__snapshots__/ui-jsx-canvas-bugs.spec.tsx.snap
Show resolved
Hide resolved
balazsbajorics
approved these changes
Oct 17, 2023
…to fix/conditionals-layout-system-for-children
gbalint
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Pasting an element into an empty conditional inside a flex container pastes the element as absolute in an awkward place
Cause & fix
layoutSystemForChildrenis not fixed up for conditionals, so the pasting logic thinks that it's a flow container with no global frame, so it bails out with a fallback and places the pasted element to top: 0, left: 0.This is fixed by actually filling in
layoutSystemForChildrenfor conditionals based on their ancestors (this is whatfillLayoutSystemForChildrenFromAncestorsdoes). This PR also changes the type ofSpecialSizeMeasurements.layoutSystemForChildrentoDetectedLayoutSystem | null.Before vs after: https://screenshot.click/16-57-e1kpo-gh6fw.mp4