Snap on convert to absolute #4371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Job #8646: Bundle Size — 63.27MiB (~-0.01%).
Warning Bundle contains 64 duplicate packages – View duplicate packages Bundle metrics
 
Bundle size by type
View job #8646 report View fix/snap-on-convert-to-absolute branch activity |
|
Performance test results: |
This reverts commit 5e31450.
bkrmendy
requested review from
gbalint,
seanparsons,
Rheeseyb,
ruggi,
balazsbajorics and
enidemi
balazsbajorics
approved these changes
Oct 13, 2023
ruggi
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Elements that use the convert to absolute and move strategy don't snap to their parent or siblings.
Fix
Remove the
isLayoutedByFlowAndNotAbsolutePositionedfromgatherParentAndSiblingTargets. SincegatherParentAndSiblingTargetsis called from the strategy, we're already certain that we want to generate snap lines for those elements, so there's no need forgatherParentAndSiblingTargetsto filter out some of them heuristically.