Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project titles, repo listing, and branch name #4367

Merged
merged 6 commits into from
Oct 13, 2023
Merged

Conversation

lankaukk
Copy link
Collaborator

@lankaukk lankaukk commented Oct 12, 2023

Problem:
The project title/repository and the branch name were uncomfortable sharing a small space together. The push local changes, pull remote changes, and merge conflicts buttons were also fighting for that space, and their text labels were confusing.

image
image

Solution

  • The repository has moved to the code editor's title bar!
  • The branch name remains in the title bar of the left menu.
  • The project title (when there is no github repo connection) remains in the left menu.
  • The pull remote changes and push local changes buttons no longer have text labels, and their color's have inverted. Only getting a subtle background color on hover.
  • When there are merge conflicts, a warning icon replaces the branch icon and the text turns red.

image
image
image
image
image

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023

Try me

@relativeci
Copy link

relativeci bot commented Oct 12, 2023

Job #8621: Bundle Size — 63.27MiB (~-0.01%).

eecd8f0(current) vs 5957b21 master#8614(baseline)

Warning

Bundle contains 64 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Improvement 1 improvement
                 Current
Job #8621
     Baseline
Job #8614
Improvement  Initial JS 35.56MiB(~-0.01%) 35.56MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 18.89% 19.53%
No change  Chunks 28 28
No change  Assets 32 32
No change  Modules 4016 4016
No change  Duplicate Modules 456 456
No change  Duplicate Code 31.36% 31.36%
No change  Packages 409 409
No change  Duplicate Packages 64 64
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
Job #8621
     Baseline
Job #8614
Improvement  JS 63.26MiB (~-0.01%) 63.26MiB
Not changed  HTML 11.54KiB 11.54KiB

View job #8621 reportView project-titles branch activity

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023

Performance test results:
(Chart1)
(Chart2)

@lankaukk lankaukk marked this pull request as ready for review October 12, 2023 18:04
@lankaukk lankaukk merged commit f795759 into master Oct 13, 2023
12 checks passed
@lankaukk lankaukk deleted the project-titles branch October 13, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants