Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspector Label Colors #4358

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Inspector Label Colors #4358

merged 1 commit into from
Oct 12, 2023

Conversation

lankaukk
Copy link
Collaborator

@lankaukk lankaukk commented Oct 11, 2023

Problem

The inspector property labels were hard to read if they were unset. Which makes it less enticing to set them!
Also, there are too many different grays in the inspector in general.

Before:
Screenshot 2023-10-11 at 11 47 33 AM

Solution

LABELS for not-yet-applied fields now always use the regular text color, not the unset one.
(With the exception of innerLabels, which are now always grey)

The VALUE of the property is what changes depending on if it is set or not.
It will be the main color if it is, greyed out if it is not.

After:
Screenshot 2023-10-11 at 11 45 47 AM

@lankaukk lankaukk changed the title changed colors Inspector Label Colors Oct 11, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023

Try me

@relativeci
Copy link

relativeci bot commented Oct 11, 2023

Job #8577: Bundle Size — 63.28MiB (~+0.01%).

97caa61(current) vs 5957b21 master#8574(baseline)

Warning

Bundle contains 64 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change Regression 1 regression
                 Current
Job #8577
     Baseline
Job #8574
Regression  Initial JS 35.57MiB(~+0.01%) 35.57MiB
No change  Initial CSS 0B 0B
No change  Cache Invalidation 18.9% 18.9%
No change  Chunks 28 28
No change  Assets 32 32
No change  Modules 4016 4016
No change  Duplicate Modules 456 456
No change  Duplicate Code 31.36% 31.36%
No change  Packages 409 409
No change  Duplicate Packages 64 64
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #8577
     Baseline
Job #8574
Regression  JS 63.27MiB (~+0.01%) 63.27MiB
Not changed  HTML 11.54KiB 11.54KiB

View job #8577 reportView control-styles branch activity

@github-actions
Copy link
Contributor

Performance test results:
(Chart1)
(Chart2)

@lankaukk lankaukk marked this pull request as ready for review October 11, 2023 16:08
@lankaukk lankaukk merged commit c9f299f into master Oct 12, 2023
13 checks passed
@lankaukk lankaukk deleted the control-styles branch October 12, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants