Fix canvas padding controls going out of sync on undo #4336
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4337
Problem:
Adjusting the padding of an element via the canvas control, and then following up with an
undo
makes the control size to lose sync with the actual value.Untitled.mov
Fix:
Instead of relying on the
useBoundingBox
hook, perform the placement calculations inside the controls, without any perf penalty.Screen.Recording.2023-10-06.at.3.25.33.PM.mov
Notes: