Gap controls centered relatively to content #4334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Job #8475: Bundle Size — 62.83MiB (~+0.01%).
Warning Bundle contains 64 duplicate packages - View duplicate packages Bundle metrics (1 change)
Bundle size by type (1 change)
View job #8475 report View feat/gap-control-content-area branch activity |
seanparsons
reviewed
Oct 6, 2023
| @@ -125,7 +125,10 @@ export const setFlexGapStrategy: CanvasStrategyFactory = ( | |||
| resizeControl, | |||
| controlWithProps({ | |||
| control: FloatingIndicator, | |||
| props: { ...props, color: colorTheme.gapControls.value }, | |||
There was a problem hiding this comment.
Does this mean that gapControls should be updated?
There was a problem hiding this comment.
mmmh it's still there for the striped background, maybe worth renaming it to gapControlsBg or something like that?
There was a problem hiding this comment.
Sounds pretty sensible to me at least.
seanparsons
approved these changes
Oct 6, 2023
|
Performance test results: |
Rheeseyb
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4333
Problem:
Flex gap handles are centered relatively to the container size. This means that they can become hard to find if the container.
E.g.
Fix:
brandNeonPinkto make them easier to spot