Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixed resize option for Groups #4325

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Conversation

ruggi
Copy link
Contributor

@ruggi ruggi commented Oct 5, 2023

Fixes #4324

Problem:

The Groups resize dropdown only shows a single Hug contents option.

Screenshot 2023-10-05 at 11 35 43 AM

Fix:

Add a Fixed option that will convert the Group to a Frame (and show a toast).

Kapture 2023-10-05 at 11 36 57

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Try me

@relativeci
Copy link

relativeci bot commented Oct 5, 2023

Job #8450: Bundle Size — 62.83MiB (~+0.01%).

40775ea(current) vs 5957b21 master#8448(baseline)

Warning

Bundle contains 64 duplicate packages - View duplicate packages

Bundle metrics (2 changes)
                 Current
Job #8450
     Baseline
Job #8448
Initial JS 35.09MiB(~+0.01%) 35.09MiB
Initial CSS 0B 0B
Cache Invalidation 18.42% 18.41%
Chunks 27 27
Assets 31 31
Modules 3974 3974
Duplicate Modules 425 425
Duplicate Code 30.92% 30.92%
Packages 409 409
Duplicate Packages 64 64
Bundle size by type (1 change)
                 Current
Job #8450
     Baseline
Job #8448
CSS 0B 0B
Fonts 0B 0B
HTML 11.43KiB 11.43KiB
IMG 0B 0B
JS 62.82MiB (~+0.01%) 62.82MiB
Media 0B 0B
Other 0B 0B

View job #8450 reportView feat/change-group-to-fixed branch activity

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Performance test results:
(Chart1)
(Chart2)

@ruggi ruggi merged commit 7fb5397 into master Oct 5, 2023
@ruggi ruggi deleted the feat/change-group-to-fixed branch October 5, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 'Fixed' option to groups resize dropdown
3 participants