Convert group child percentage pins to pixel based pins. #4314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `whenReplacingPercentageValues` property to `SetCssLengthProperty`. - `runSetCssLengthProperty` now adds an appropriate toast when replacing a percentage based property and when it is instructed to warn in this particular case. - `setElementPins` now replaces the children's pin values with pixel based ones in all cases regardless of what was there before. - `runPushIntendedBoundsAndUpdateGroups` ensures that any toasts are carried forward in the editor state patch. - The patching part of `runShowToastCommand` has been extracted into a utility function `addToastPatch`.
seanparsons
requested review from
gbalint,
Rheeseyb,
ruggi,
balazsbajorics,
enidemi and
bkrmendy
| @@ -265,7 +265,7 @@ describe('Keyboard Absolute Resize E2E', () => { | |||
| }) | |||
| }) | |||
|
|
|||
| it('keeps trueuing up groups as directions change', async () => { | |||
There was a problem hiding this comment.
haha it's like queueing but trueueing
balazsbajorics
approved these changes
Oct 4, 2023
Job #8415: Bundle Size — 62.81MiB (~+0.01%).
Warning Bundle contains 64 duplicate packages - View duplicate packages Bundle metrics (2 changes)
Bundle size by type (1 change)
View job #8415 report View feature/convert-group-child-perc... branch activity |
|
Performance test results: |
Rheeseyb
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4299
Problem:
Percentage based pins for the children of a group don't really make any sense.
Fix:
In the following cases we now replace the pins of the children of a group with pixel based pins regardless of whatever they had before:
Should a percentage based pin be replaced in this way, we show a toast indicating that one or more of those has been replaced.
Commit Details:
whenReplacingPercentageValuesproperty toSetCssLengthProperty.runSetCssLengthPropertynow adds an appropriate toast when replacing a percentage based property and when it is instructed to warn in this particular case.setElementPinsnow replaces the children's pin values with pixel based ones in all cases regardless of what was there before.runPushIntendedBoundsAndUpdateGroupsensures that any toasts are carried forward in the editor state patch.runShowToastCommandhas been extracted into a utility functionaddToastPatch.