Completely disallow percentage based group children. #4302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change `InvalidGroupState` value `'child-has-percentage-pins-without-group-size'` to `'child-has-percentage-pins'`. - Remove a handful of checks to see if the groups have an explicit size. - Add a test that checks for a child with percentage pins but explicit dimensions.
seanparsons
requested review from
gbalint,
Rheeseyb,
ruggi,
balazsbajorics,
enidemi and
bkrmendy
balazsbajorics
approved these changes
Oct 3, 2023
gbalint
approved these changes
Oct 3, 2023
Job #8386: Bundle Size — 62.78MiB (~-0.01%).
Warning Bundle contains 64 duplicate packages - View duplicate packages Bundle metrics (2 changes)
Bundle size by type (1 change)
View job #8386 report View feature/disallow-percentage-base... branch activity |
|
Performance test results: |
seanparsons
deleted the
feature/disallow-percentage-based-group-children
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly Fixes #4299
Problem:
Group children with percentage pins are problematic regardless of if the group has an explicit size.
Fix:
Widen the threshold for the existing check for group children with percentage pins by removing the check for the explicit size of a group.
Commit Details:
InvalidGroupStatevalue'child-has-percentage-pins-without-group-size'to'child-has-percentage-pins'.