Check for existing scope on possible cyclic dependencies #4292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rheeseyb
requested review from
gbalint,
seanparsons,
ruggi,
balazsbajorics,
enidemi and
bkrmendy
Job #8358: Bundle Size — 62.78MiB (~+0.01%).
Warning Bundle contains 64 duplicate packages - View duplicate packages Bundle metrics (1 change)
Bundle size by type (1 change)
View job #8358 report View fix/multiple-import-handling branch activity |
| return existingScope == null ? left(msg) : right(existingScope) | ||
| }, | ||
| (resolvedFilePath) => { | ||
| resolvedFromThisOrigin[toImport] = null // We use null as a marker to indicate that we have started resolving, but not completed yet |
There was a problem hiding this comment.
can't we use some other marker like 'started-resolving'? I think the !== undefined (from above) is very unexpressive, and the shape of the code would stay the same
balazsbajorics
approved these changes
Oct 2, 2023
|
Performance test results: |
bkrmendy
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Whilst evaluating a project inside the canvas, when we reach an import statement that has already been resolved we assume that it is a cyclic dependency, and fall back to the default import handling, meaning we won't wrap the imported components and therefore can't focus and edit them.
This can be shown by having a file A import file B, and then have multiple files import file A, which is shown here - in this project, the
Textcomponent cannot be focused, as the import statementimport { Text } from '/src/text'insidecard.jsis evaluated twice. To see that working on this branch, test the project hereFix:
Rather than immediately assume that we have hit upon a cyclic dependency that we can't handle, we now keep a reference to the scope created by each import, and return that if it exists. If no such scope exists (and we have already resolved that import), then we will fall back to the default import handling.