Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More understandable constrained labels #4285

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

ruggi
Copy link
Contributor

@ruggi ruggi commented Oct 2, 2023

Fixes #4284

Problem:

The labels for the constrained/unconstrained dropdowns for group children are hard to understand.

Kapture 2023-10-02 at 13 16 12

Fix:

  • Constrained becomes Fixed
  • Unconstrained becomes Scale with parent

Kapture 2023-10-02 at 13 15 21

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Try me

@relativeci
Copy link

relativeci bot commented Oct 2, 2023

Job #8341: Bundle Size — 62.71MiB (~+0.01%).

7ac1c27(current) vs 5957b21 master#8340(baseline)

Warning

Bundle contains 64 duplicate packages - View duplicate packages

Bundle metrics (2 changes)
                 Current
Job #8341
     Baseline
Job #8340
Initial JS 34.97MiB(~+0.01%) 34.97MiB
Initial CSS 0B 0B
Cache Invalidation 18.39% 19.36%
Chunks 27 27
Assets 31 31
Modules 3971 3971
Duplicate Modules 422 422
Duplicate Code 30.83% 30.83%
Packages 409 409
Duplicate Packages 64 64
Bundle size by type (1 change)
                 Current
Job #8341
     Baseline
Job #8340
CSS 0B 0B
Fonts 0B 0B
HTML 11.43KiB 11.43KiB
IMG 0B 0B
JS 62.7MiB (~+0.01%) 62.7MiB
Media 0B 0B
Other 0B 0B

View job #8341 reportView fix/constrained-labels-inspector branch activity

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Performance test results:
(Chart1)
(Chart2)

@ruggi ruggi merged commit 319f550 into master Oct 2, 2023
12 checks passed
@ruggi ruggi deleted the fix/constrained-labels-inspector branch October 2, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make constrained/unconstrained inspector labels easier to understand
3 participants