Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/mini grid design fixes #4275

Merged
merged 9 commits into from
Oct 2, 2023
Merged

Conversation

balazsbajorics
Copy link
Contributor

@balazsbajorics balazsbajorics commented Sep 29, 2023

Fixes #4274

Mini design fixes for the Grid Panels system

Commit Details:

  • Panel reorder: Re-enabled the logic that only shows a dropline if dropping the panel there would result in a layout change
  • Panel reorder: the area above the canvas is a drop target now so you can easily reorder panels to the other side of the editor
  • The code editor has a somewhat nicer title bar made by Malte last friday
  • The code editor title bar's minimize and maximize buttons are wired in:
    • Minimize moves it below the Navigator
    • Maximize move it to be the leftmost panel
  • A fix of an accidental mutation in an update function
  • The panel layout's padding around the window border is significantly reduced to 8px
  • Hiding that weird little square thumbnail that would travel with the reordered panels :)

@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2023

Try me

@relativeci
Copy link

relativeci bot commented Sep 29, 2023

Job #8336: Bundle Size — 62.78MiB (+0.12%).

6b9984a(current) vs 5957b21 master#8329(baseline)

Warning

Bundle contains 64 duplicate packages - View duplicate packages

Bundle metrics (5 changes)
                 Current
Job #8336
     Baseline
Job #8329
Initial JS 35.04MiB(+0.22%) 34.96MiB
Initial CSS 0B 0B
Cache Invalidation 21.33% 18.37%
Chunks 27 27
Assets 31 31
Modules 3972(+0.05%) 3970
Duplicate Modules 424(+0.47%) 422
Duplicate Code 30.9%(+0.23%) 30.83%
Packages 409 409
Duplicate Packages 64 64
Bundle size by type (1 change)
                 Current
Job #8336
     Baseline
Job #8329
CSS 0B 0B
Fonts 0B 0B
HTML 11.43KiB 11.43KiB
IMG 0B 0B
JS 62.76MiB (+0.12%) 62.69MiB
Media 0B 0B
Other 0B 0B

View job #8336 reportView chore/mini-grid-design-fixes branch activity

@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2023

Performance test results:
(Chart1)
(Chart2)

working[update.columnIndex].panels,
)
working[update.columnIndex] = {
...working[update.columnIndex],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extracting out the existing value into a variable would probably make this a little cleaner.

working[update.columnIndex].panels,
)
working[update.columnIndex] = {
...working[update.columnIndex],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extracting out the existing value into a variable would probably make this a little cleaner.

@balazsbajorics balazsbajorics merged commit c48eaef into master Oct 2, 2023
@balazsbajorics balazsbajorics deleted the chore/mini-grid-design-fixes branch October 2, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small design tweaks and minor fixes for the Grid panel layout
5 participants