Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap in div shortcut #4269

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Wrap in div shortcut #4269

merged 2 commits into from
Oct 2, 2023

Conversation

bkrmendy
Copy link
Contributor

Description

This PR adds a shortcut that wraps the selected elements in a div when cmd + enter is pressed

@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2023 •
edited
Loading

Try me

@relativeci
Copy link

relativeci bot commented Sep 29, 2023

Job #8301: Bundle Size — 62.67MiB (~+0.01%).

abeeda0(current) vs 5957b21 master#8294(baseline)

⚠️ Bundle contains 64 duplicate packages

Metrics (2 changes)
                 Current
Job #8301		      Baseline
Job #8294
Initial JS 34.94MiB(~+0.01%) 34.93MiB
Initial CSS 0B 0B
Cache Invalidation 18.35% 0%
Chunks 27 27
Assets 31 31
Modules 3970 3970
Duplicate Modules 422 422
Duplicate Code 30.84% 30.84%
Packages 409 409
Duplicate Packages 64 64
Total size by type (1 change)
                 Current
Job #8301		      Baseline
Job #8294
CSS 0B 0B
Fonts 0B 0B
HTML 11.43KiB 11.43KiB
IMG 0B 0B
JS 62.66MiB (~+0.01%) 62.66MiB
Media 0B 0B
Other 0B 0B

View job #8301 report View feature/wrap-in-div-on-cmd-enter branch activity

@github-actions
Copy link
Contributor

Performance test results:
(Chart1)
(Chart2)

@bkrmendy bkrmendy merged commit 7b4cd65 into master Oct 2, 2023
8 checks passed
@bkrmendy bkrmendy deleted the feature/wrap-in-div-on-cmd-enter branch October 2, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rheeseyb Rheeseyb Rheeseyb approved these changes

@gbalint gbalint gbalint approved these changes

@seanparsons seanparsons Awaiting requested review from seanparsons

@ruggi ruggi Awaiting requested review from ruggi

@balazsbajorics balazsbajorics Awaiting requested review from balazsbajorics

@enidemi enidemi Awaiting requested review from enidemi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bkrmendy @gbalint @Rheeseyb