Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove extra space from popup lists #4267

Merged
merged 1 commit into from
Sep 28, 2023
Merged

remove extra space from popup lists #4267

merged 1 commit into from
Sep 28, 2023

Conversation

lankaukk
Copy link
Collaborator

Before, there was pain Now, there is not
Screenshot 2023-09-28 at 2 21 25 PM Screenshot 2023-09-28 at 2 20 41 PM

@lankaukk lankaukk marked this pull request as ready for review September 28, 2023 18:22
@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2023

Try me

@relativeci
Copy link

relativeci bot commented Sep 28, 2023

Job #8284: Bundle Size — 62.67MiB (~-0.01%).

90afdf1(current) vs 5957b21 master#8262(baseline)

⚠️ Bundle contains 64 duplicate packages

Metrics (2 changes)
                 Current
Job #8284
     Baseline
Job #8262
Initial JS 34.93MiB(~-0.01%) 34.93MiB
Initial CSS 0B 0B
Cache Invalidation 19.32% 0%
Chunks 27 27
Assets 31 31
Modules 3970 3970
Duplicate Modules 422 422
Duplicate Code 30.84% 30.84%
Packages 409 409
Duplicate Packages 64 64
Total size by type (1 change)
                 Current
Job #8284
     Baseline
Job #8262
CSS 0B 0B
Fonts 0B 0B
HTML 11.43KiB 11.43KiB
IMG 0B 0B
JS 62.66MiB (~-0.01%) 62.66MiB
Media 0B 0B
Other 0B 0B

View job #8284 reportView kill-pain-space branch activity

@github-actions
Copy link
Contributor

Performance test results:
(Chart1)
(Chart2)

Copy link
Member

@maltenuhn maltenuhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just about within my level of proficiency to approve, I think

@lankaukk lankaukk merged commit b24918a into master Sep 28, 2023
@lankaukk lankaukk deleted the kill-pain-space branch September 28, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants