Delete existing empty spans when leaving text edit mode

[ruggi]

Fixes #4265

Problem:

When leaving text edit mode, new elements are deleted, but existing ones are kept.

Fix:

Update the behavior so it also removes existing empty elements if:

1. the element is a span
2. and it does not have event handlers

[github-actions]

Try me

[relativeci]

Job #8320: Bundle Size — 62.7MiB (~+0.01%).

d6cba5c(current) vs 5957b21 master#8318(baseline)

⚠️ Bundle contains 64 duplicate packages

Metrics (2 changes)

	Current Job #8320	Baseline Job #8318
Initial JS	34.96MiB(~+0.01%)	34.96MiB
Initial CSS	0B	0B
Cache Invalidation	18.37%	19.35%
Chunks	27	27
Assets	31	31
Modules	3970	3970
Duplicate Modules	422	422
Duplicate Code	30.83%	30.83%
Packages	409	409
Duplicate Packages	64	64

Total size by type (1 change)

	Current Job #8320	Baseline Job #8318
CSS	0B	0B
Fonts	0B	0B
HTML	11.43KiB	11.43KiB
IMG	0B	0B
JS	62.69MiB (~+0.01%)	62.68MiB
Media	0B	0B
Other	0B	0B

---

View job #8320 report View fix/delete-existing-empty-spans branch activity

[github-actions]

Performance test results:

[balazsbajorics]

I tried the try me link and something is very broken, the Enter acts like a delete button for divs that don't already contain text, and text insertion also immediately quits.

Bug aside, I think for non-new elements we should be more careful, and make sure it's a span and not a div and/or that it doesn't have dimensions, backgroundColor, etc. So in general, we want the feature to clean up invisible leftover, but do not cause a headache if you have something selected and you accidentally press Enter.

[ruggi]

I tried the try me link and something is very broken, the Enter acts like a delete button for divs that don't already contain text, and text insertion also immediately quits.

Bug aside, I think for non-new elements we should be more careful, and make sure it's a span and not a div and/or that it doesn't have dimensions, backgroundColor, etc. So in general, we want the feature to clean up invisible leftover, but do not cause a headache if you have something selected and you accidentally press Enter.

Updated - the behavior only triggers for span elements without styling nor event handlers!