More tolerant safe gaps #4262
Merged
More tolerant safe gaps #4262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanparsons
approved these changes
Sep 28, 2023
Job #8280: Bundle Size — 62.67MiB (~-0.01%).
Metrics (2 changes)
Total size by type (1 change)
View job #8280 report View fix/safe-gap-12-4 branch activity |
|
Performance test results: |
balazsbajorics
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4261
Problem:
The selection safe gap feels a bit too aggressive with the current 20px threshold + 6px gap.
Fix:
This PR adjusts the thresholds to 12px for the safe gap threshold (meaning that safe gaps will be applied if any dimension is smaller than it) and 4px for the gap itself.