Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dim overlapping labels #4259

Merged
merged 3 commits into from
Sep 29, 2023
Merged

Dim overlapping labels #4259

merged 3 commits into from
Sep 29, 2023

Conversation

ruggi
Copy link
Contributor

@ruggi ruggi commented Sep 28, 2023 •
edited
Loading

Fixes #4271

Problem:

When there close elements, the size labels can get in the way of selecting neighbors.

Kapture 2023-09-29 at 13 03 34

Fix:

When the mouse is over the label, if the label is covering other elements, dim the label to almost-invisible.

Kapture 2023-09-29 at 13 04 31

@ruggi ruggi changed the title use "group" for group size label (wip) dim overlapping labels Sep 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2023 •
edited
Loading

Try me

@relativeci
Copy link

relativeci bot commented Sep 28, 2023 •
edited
Loading

Job #8314: Bundle Size — 62.69MiB (~+0.01%).

3d409ac(current) vs 5957b21 master#8311(baseline)

⚠️ Bundle contains 64 duplicate packages

Metrics (2 changes)
                 Current
Job #8314		      Baseline
Job #8311
Initial JS 34.96MiB(~+0.01%) 34.96MiB
Initial CSS 0B 0B
Cache Invalidation 18.37% 11.14%
Chunks 27 27
Assets 31 31
Modules 3970 3970
Duplicate Modules 422 422
Duplicate Code 30.83% 30.83%
Packages 409 409
Duplicate Packages 64 64
Total size by type (1 change)
                 Current
Job #8314		      Baseline
Job #8311
CSS 0B 0B
Fonts 0B 0B
HTML 11.43KiB 11.43KiB
IMG 0B 0B
JS 62.68MiB (~+0.01%) 62.68MiB
Media 0B 0B
Other 0B 0B

View job #8314 report View feat/dim-overlap-labels branch activity

@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2023 •
edited
Loading

Performance test results:
(Chart1)
(Chart2)

@ruggi ruggi force-pushed the feat/dim-overlap-labels branch from 531d36e to a456ebf Compare September 29, 2023 07:38
@ruggi ruggi changed the title (wip) dim overlapping labels Dim overlapping labels Sep 29, 2023
@ruggi ruggi marked this pull request as ready for review September 29, 2023 11:07
Rheeseyb
Rheeseyb approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@Rheeseyb Rheeseyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@ruggi ruggi merged commit 5624cf8 into master Sep 29, 2023
10 checks passed
@ruggi ruggi deleted the feat/dim-overlap-labels branch September 29, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkrmendy bkrmendy bkrmendy approved these changes

@Rheeseyb Rheeseyb Rheeseyb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dim overlapping size labels
3 participants
@ruggi @Rheeseyb @bkrmendy