-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide safe gaps after drag threshold #4254
Conversation
Job #8298: Bundle Size — 62.67MiB (~+0.01%).
Metrics (2 changes)
Total size by type (1 change)
View job #8298 report View fix/safe-gaps-after-threshold branch activity |
editor/src/components/canvas/canvas-strategies/interaction-state.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the new behavior! but I wouldn't add hasBeenPastThreshold
to the interactionState to avoid inflating it and instead use drag != null.
oh man, nice! yeah I added that because I did not figure out the |
# Conflicts: # editor/src/components/canvas/controls/bounding-box-hooks.ts
Fixes #4253
Problem:
Fix:
max-content
dimensionsScreen.Recording.2023-09-28.at.1.19.52.PM.mov