Respect spans when resizing grid items #6683
Assignees
Comments
ruggi
added a commit
that referenced
this issue
Nov 27, 2024
**Problem:** Resizing grid cells always forces explicit numerical placement pins, chomping any `span`s that may have been defined on the cell. **Fix:** After determining the right numerical positions for the resized cell bounds, do a normalization pass so that the new grid props are rewritten to respect the new bounds but also to express them with `spans` if the original pins were spans in the first place. For example, assuming enlarging to the right by 1 cell: | Initial | Result | |--------|----------| | `gridColumn: span 2` | `gridColumn: span 3` | | `gridColumn 3 / span 2` | `gridColumn: 3 / span 3` | **Manual Tests:** I hereby swear that: - [x] I opened a hydrogen project and it loaded - [x] I could navigate to various routes in Play mode Fixes #6683
liady
pushed a commit
that referenced
this issue
Dec 13, 2024
**Problem:** Resizing grid cells always forces explicit numerical placement pins, chomping any `span`s that may have been defined on the cell. **Fix:** After determining the right numerical positions for the resized cell bounds, do a normalization pass so that the new grid props are rewritten to respect the new bounds but also to express them with `spans` if the original pins were spans in the first place. For example, assuming enlarging to the right by 1 cell: | Initial | Result | |--------|----------| | `gridColumn: span 2` | `gridColumn: span 3` | | `gridColumn 3 / span 2` | `gridColumn: 3 / span 3` | **Manual Tests:** I hereby swear that: - [x] I opened a hydrogen project and it loaded - [x] I could navigate to various routes in Play mode Fixes #6683
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: