Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct the order of the split padding input to be Top, Right, Bottom, Left #6220

Closed
liady opened this issue Aug 9, 2024 · 0 comments · Fixed by #6221
Closed

Correct the order of the split padding input to be Top, Right, Bottom, Left #6220

liady opened this issue Aug 9, 2024 · 0 comments · Fixed by #6221
Assignees
@liady

Comments

@liady
Copy link
Contributor

liady commented Aug 9, 2024 •
edited
Loading

correct the order of the split padding input to be Top, Right, Bottom, Left (instead of Top, Right, Left, Bottom), without changing the current order of the split border-radius inputs. Should look like this
Image
Image
@liady liady mentioned this issue Aug 9, 2024
Open
1 task
@liady liady changed the title correct the order of the split padding input to be Top, Right, Bottom, Left (instead of Top, Right, Left, Bottom), without changing the current order of the split border-radius inputs. Should look like this Correct the order of the split padding input to be Top, Right, Bottom, Left Aug 9, 2024
@liady liady self-assigned this Aug 9, 2024
@liady liady mentioned this issue Aug 9, 2024
Merged
2 tasks
liady added a commit that referenced this issue Dec 13, 2024
@liady
Allow setting the four-sides order for the split input control (#6221)
40ccbe2 
**Problem:**
the order of the padding controls is incorrect, it follows the order of
the border radius controls but should be a bit different.
this is the first part of #6140

**Fix:**
allow changing the order of the padding controls without changing the
order of the border controls (passing it from outside)

![Image](https://github.com/user-attachments/assets/1a5b3abe-d710-4ee1-8a3c-615fb6b14133)

**Manual Tests:**
I hereby swear that:

- [X] I opened a hydrogen project and it loaded
- [X] I could navigate to various routes in Preview mode

Fixes #6220 that was extracted from #6140
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liady liady

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow setting the four-sides order for the split input control concrete-utopia/utopia
1 participant
@liady