Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable base url for comments test #4715

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Configurable base url for comments test #4715

merged 1 commit into from
Jan 10, 2024

Conversation

bkrmendy
Copy link
Contributor

@bkrmendy bkrmendy commented Jan 10, 2024 •
edited
Loading

Problem

The test for comments runs on pizza, even if the actual test script is run on localhost. This is not ideal for testing code that's only available locally.

Fix

Adds an env var to the test called BASE_URL, which specifies where the test should run. It defaults to localhost, and set to pizza in the CI job.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 10, 2024 •
edited
Loading

Try me

@bkrmendy bkrmendy mentioned this pull request Jan 10, 2024
Merged
@relativeci RelativeCI
Copy link

relativeci bot commented Jan 10, 2024

Job #9807: Bundle Size — 62.2MiB (~-0.01%).

bd10642(current) vs df0030c master#9798(baseline)

Warning

Bundle contains 66 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change Improvement 1 improvement
                 Current
Job #9807		      Baseline
Job #9798
Improvement  Initial JS 45.4MiB(~-0.01%) 45.4MiB
No change  Initial CSS 0B 0B
No change  Cache Invalidation 19.86% 19.86%
No change  Chunks 26 26
No change  Assets 30 30
No change  Modules 4362 4362
No change  Duplicate Modules 471 471
No change  Duplicate Code 30.75% 30.75%
No change  Packages 462 462
No change  Duplicate Packages 65 65
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
Job #9807		      Baseline
Job #9798
Improvement  JS 62.19MiB (~-0.01%) 62.19MiB
Not changed  HTML 11.54KiB 11.54KiB

View job #9807 report View tests/comments-test-local branch activity

@github-actions GitHub Actions
Copy link
Contributor

Performance test results:
(Chart1)
(Chart2)

@bkrmendy bkrmendy merged commit d5bf316 into master Jan 10, 2024
13 checks passed
@bkrmendy bkrmendy deleted the tests/comments-test-local branch January 10, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balazsbajorics balazsbajorics balazsbajorics approved these changes

@gbalint gbalint gbalint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bkrmendy @gbalint @balazsbajorics