-
Notifications
You must be signed in to change notification settings - Fork 171
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feature(grid) Grid Child Pin Outlines (#6617)
- Fixed `parseGridRange` to more closely reflect the behaviour in browsers. - Renamed `elementStyle` to `computedStyle` in `getSpecialMeasurements` for clarity. - `PinLines` excludes grid cells from those elements which will get regular pin outlines. - `PinOutlineProps` now has `endX` and `endY` properties, along with supporting `string` values for most of the properties. - `PinOutline` now defers a lot of the calculations down into the CSS. - Added `GridElementContainingBlocks` into the controls hierarchy. - Implemented `collectGridPinOutlines` which handles the more complicated case that grids present. - Implemented `GridElementContainingBlock` to render `PinOutline` instances for the grid children.
- Loading branch information
1 parent
16a0ff6
commit c7c479b
Showing
12 changed files
with
1,078 additions
and
95 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.