mini PR: update inspector group tests (#4415)

* fixing Group tests * Update inspector-end-to-end-tests.spec.browser2.tsx * Update inspector-end-to-end-tests.spec.browser2.tsx
concrete-utopia · Oct 24, 2023 · 6155cf4 · 6155cf4
1 parent 6417d38
commit 6155cf4
Showing 1 changed file with 13 additions and 19 deletions.
diff --git a/editor/src/components/inspector/common/inspector-end-to-end-tests.spec.browser2.tsx b/editor/src/components/inspector/common/inspector-end-to-end-tests.spec.browser2.tsx
@@ -3207,13 +3207,7 @@ describe('inspector tests with real metadata', () => {
   })
 
   describe('groups', () => {
-    setFeatureForBrowserTestsUseInDescribeBlockOnly('Simplified Layout Section', false)
-    function expectGroupToast(renderResult: EditorRenderResult, state: InvalidGroupState) {
-      const editorState = renderResult.getEditorState().editor
-      expect(editorState.toasts.length).toBe(1)
-      expect(editorState.toasts[0].level).toBe('ERROR')
-      expect(editorState.toasts[0].message).toBe(invalidGroupStateToString(state))
-    }
+    setFeatureForBrowserTestsUseInDescribeBlockOnly('Simplified Layout Section', true)
     it('ignores removing pins from a group child', async () => {
       const renderResult = await renderTestEditorWithCode(
         makeTestProjectCodeWithSnippetStyledComponents(`
@@ -3249,17 +3243,17 @@ describe('inspector tests with real metadata', () => {
       })
 
       const leftControl = (await renderResult.renderedDOM.findByTestId(
-        'position-left-number-input',
+        'frame-left-number-input',
       )) as HTMLInputElement
 
       expect(leftControl.value).toBe('30')
 
       const elementFrame = getFrame(targetPath, renderResult)
 
-      await setControlValue('position-left-number-input', '', renderResult.renderedDOM)
+      await setControlValue('frame-left-number-input', '', renderResult.renderedDOM)
 
+      // Nothing changed
       expect(getFrame(targetPath, renderResult)).toBe(elementFrame)
-      expectGroupToast(renderResult, 'child-has-missing-pins')
     })
     it('ignores setting percentage pins on a group', async () => {
       const renderResult = await renderTestEditorWithCode(
@@ -3301,17 +3295,17 @@ describe('inspector tests with real metadata', () => {
       })
 
       const leftControl = (await renderResult.renderedDOM.findByTestId(
-        'position-left-number-input',
+        'frame-left-number-input',
       )) as HTMLInputElement
 
       expect(leftControl.value).toBe('10')
 
       const elementFrame = getFrame(targetPath, renderResult)
 
-      await setControlValue('position-left-number-input', '25%', renderResult.renderedDOM)
+      await setControlValue('frame-left-number-input', '25%', renderResult.renderedDOM)
 
+      // Nothing changed
       expect(getFrame(targetPath, renderResult)).toBe(elementFrame)
-      expectGroupToast(renderResult, 'group-has-percentage-pins')
     })
     it('ignores settings percentage pins on a group child if the parent has no explicit width and height', async () => {
       const renderResult = await renderTestEditorWithCode(
@@ -3354,17 +3348,17 @@ describe('inspector tests with real metadata', () => {
       })
 
       const leftControl = (await renderResult.renderedDOM.findByTestId(
-        'position-left-number-input',
+        'frame-left-number-input',
       )) as HTMLInputElement
 
       expect(leftControl.value).toBe('30')
 
       const elementFrame = getFrame(targetPath, renderResult)
 
-      await setControlValue('position-left-number-input', '25%', renderResult.renderedDOM)
+      await setControlValue('frame-left-number-input', '25%', renderResult.renderedDOM)
 
+      // Nothing changed
       expect(getFrame(targetPath, renderResult)).toBe(elementFrame)
-      expectGroupToast(renderResult, 'child-has-percentage-pins')
     })
     it('ignores settings percentage pins on a group child if the parent has explicit width and height', async () => {
       const renderResult = await renderTestEditorWithCode(
@@ -3408,17 +3402,17 @@ describe('inspector tests with real metadata', () => {
       })
 
       const leftControl = (await renderResult.renderedDOM.findByTestId(
-        'position-left-number-input',
+        'frame-left-number-input',
       )) as HTMLInputElement
 
       expect(leftControl.value).toBe('30')
 
       const elementFrame = getFrame(targetPath, renderResult)
 
-      await setControlValue('position-left-number-input', '25%', renderResult.renderedDOM)
+      await setControlValue('frame-left-number-input', '25%', renderResult.renderedDOM)
 
+      // Nothing changed
       expect(getFrame(targetPath, renderResult)).toBe(elementFrame)
-      expectGroupToast(renderResult, 'child-has-percentage-pins')
     })
 
     describe('group children', () => {