-
Notifications
You must be signed in to change notification settings - Fork 171
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
**Problem:** Pasting an element into a grid doesn't place the new element _into_ the grid's placement logic. **Fix:** If the target parent is a grid, remove flow properties from the pasted element, which will be then placed at the first valid coordinates following `auto` logic. In the future we might revisit this with a bit more heuristics to determine "empty" cells to place the element into, but for now the current logic should be more than enough. | Before | After | |-------|----------| | ![Kapture 2024-08-22 at 11 30 59](https://github.com/user-attachments/assets/16a4b479-6fa8-4962-8990-5fb1356d8537) | ![Kapture 2024-08-22 at 11 29 34](https://github.com/user-attachments/assets/f248cb1c-453d-4051-b2c0-30257c54ee2a) | **Manual Tests:** I hereby swear that: - [x] I opened a hydrogen project and it loaded - [x] I could navigate to various routes in Preview mode Fixes #6253
- Loading branch information
Showing
1 changed file
with
39 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters