Skip to content

Commit

Permalink
fix(editor) Honours Props For Fragment Components (#6165)
Browse files Browse the repository at this point in the history
- `absoluteMoveStrategy` modified to handle the changed result from
`honoursPropsPosition`.
- Fixed `getFitness` function for convert to absolute and move strategy,
as it was returning a fitness above zero for a keyboard interaction.
- `keyboardAbsoluteMoveStrategy` modified to handle the changed result
from `honoursPropsPosition`.
- Fixed keyboard resize and move tests as they were using incorrect
element paths.
- `supportsAbsoluteResize` modified to handle the changed result from
`honoursPropsPosition`.
- `getMoveCommandsForSelectedElement` lost the invariants as they
weren't that necessary and were the cause of the browser tests
deadlocking.
- `getMoveCommandsForSelectedElement` is now a little more flexible if
the parent bounds are not available, as it's possible to move something
with a delta.
- Added `FrameWithFourPoints`, `rectangleToFourFramePoints` and
`FrameWithFourToSixPoints`.
- DOM walker now checks for descendants of valid paths to catch elements
inside fragments.
- `componentHonoursPropsPosition` now returns detail of what exactly the
component honours so that it's possible to get the detail of `position:
'absolute'` from this as well as the metadata.
- Both `componentHonoursPropsPosition` and `componentHonoursPropsSize`
now peak inside fragments at the root of their components.
- Fixed a bug in `propsStyleIsSpreadInto` where it wasn't covering
`props.style` being set directly.
- Added `metadataHasPositionAbsoluteOrNull` to make specifying certain
cases easier.
- Changed the default value for the position in
`emptySpecialSizeMeasurements` to `null`.
  • Loading branch information
seanparsons authored Aug 7, 2024
1 parent 9ef5cac commit 0ea8d95
Show file tree
Hide file tree
Showing 23 changed files with 1,259 additions and 405 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ Object {
"parentLayoutSystem": "flow",
"parentPadding": Object {},
"parentTextDirection": "ltr",
"position": "static",
"position": null,
"providesBoundsForAbsoluteChildren": false,
"renderedChildrenCount": 0,
"rowGap": null,
Expand Down Expand Up @@ -382,7 +382,7 @@ Object {
"parentLayoutSystem": "flow",
"parentPadding": Object {},
"parentTextDirection": "ltr",
"position": "static",
"position": null,
"providesBoundsForAbsoluteChildren": false,
"renderedChildrenCount": 0,
"rowGap": null,
Expand Down
Loading

0 comments on commit 0ea8d95

Please sign in to comment.