-
Notifications
You must be signed in to change notification settings - Fork 171
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(import): allow continuing the import after an error (#6614)
This PR adds the ability to control the import process after an error: 1. Import a different project 2. Decide to continue anyway (for example to correct it using our editor). This PR distinguishes between an `Error` (that can be continued) and a `Critical Error` (for example a non-existent repo) - that we cannot recover from. **PR details:** 1. In [editor/src/core/shared/github/operations/load-branch.ts](https://github.com/concrete-utopia/utopia/pull/6614/files#diff-3c1474cac72b0e757d951539630bd72175135c05eddbff91d9f10639d2796440) this PR adds the ability to stop before dependencies fetching and resume afterwards 2. In [editor/src/components/editor/import-wizard/import-wizard.tsx](https://github.com/concrete-utopia/utopia/pull/6614/files#diff-a1ec93eec4b0720f01ff6ec77bb4efb6cc3ac0ba4297d3fe7bb77049c601ca94) this PR adds the UI for displaying the correct status/buttons according to the current import state. 3. The rest of the changes are mostly actions/state changes. For example this flow: 1. Importing a non-existing repo (critical error) 2. Then importing a project with errors (TS/server packages, etc), choosing to continue importing 3. Deciding to import a different project - which is a success <video src="https://github.com/user-attachments/assets/39eaeedd-14fd-4819-b590-39a92629ad8e"></video> Current design: <img width="693" alt="image" src="https://github.com/user-attachments/assets/a609068f-dece-4448-a31d-c266969a6341"> **Manual Tests:** I hereby swear that: - [x] I opened a hydrogen project and it loaded - [x] I could navigate to various routes in Play mode
- Loading branch information
Showing
16 changed files
with
333 additions
and
101 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.