Patch/expected lite #1442
Closed
Patch/expected lite #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All green in build 1 (
|
|
If this patch is not appropriate, would it be possible to have some guidance on mixing tagged releases with comming/date versioning of packages? Ie having version 0.3.0 and 03102019 ? to get the upstream changes |
|
First, where did you find that patch? Is there any new version to be released soon? If yes, I prefer droping the support and adding the patch for the new version only. |
|
I tagged the commit I cherry picked with my commit. Any new release will include the fix I'll mark this as a draft since there maybe be a new release soon |
|
fixed #1444 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: expected-lite/0.3.0
conan-center hook activated.