COMCL-333: Fix Bug With Empty Target Contact For File Upload Activities #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahrukh-compuco
force-pushed
the
COMCL-333-fix-activity-target-contact-bug
branch
from
460b915 to
bef0b7a
Compare
shahrukh-compuco
force-pushed
the
COMCL-333-fix-activity-target-contact-bug
branch
from
bef0b7a to
5da5094
Compare
erawat
approved these changes
Nov 9, 2023
shahrukh-compuco
deleted the
COMCL-333-fix-activity-target-contact-bug
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Civi core errors out if an empty string is posted target contact id while editing file upload activity. This pr resolves the bug by removing the target contact id param from activity form if its submitted value is empty string.
Before
After