Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BTHAB-271: Fix Invoice And Payment Status Bugs For Quotations #988

Conversation

shahrukh-compuco
Copy link

Overview

The payment and invoice statuses were being calculated in accordance to just invoiced amount without considering the quoted amount and the calculations previously also took into account the deleted invoices which were resulting in incorrect statuses calculations

Before

These were the issues previously

  • Quotation's payment status changed to fully paid upon paying total quotation amount partially
  • Quotation's payment status did not change to overpaid even after paying more than quoted amount
  • Quotation's payment status did not change to fully paid even after paying in full
  • Deleting a invoice did not change the payment and invoice statuses correctly

After

All issues described above are fixed and now quotation's payment and invoice statuses are being calculated correctly after creation, deletion and payment of invoices.

The payment and invoice statuses were being calculated in accordance to just invoiced amount without considering the quoted amount and the calculations previously also took into account the deleted invoices which were resulting in incorrect statuses calculations
@shahrukh-compuco shahrukh-compuco force-pushed the BTHAB-271-fix-invoice-and-payment-status-bugs branch from c51eef2 to 1a7c114 Compare October 23, 2023 08:25
@shahrukh-compuco shahrukh-compuco merged commit e251b61 into BTHAB-3-workstream Oct 25, 2023
2 checks passed
@shahrukh-compuco shahrukh-compuco deleted the BTHAB-271-fix-invoice-and-payment-status-bugs branch October 25, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants