forked from civicrm/org.civicrm.civicase
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BTHAB-185: Implement invoicing and payment statuses for quotations #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erawat
force-pushed
the
BTHAB-185-display-statuses
branch
4 times, most recently
from
September 21, 2023 11:27
138e258
to
0e20b36
Compare
CRM/Civicase/DAO/CaseSalesOrder.php
Outdated
@@ -174,7 +192,7 @@ public function __construct() { | |||
* Whether to return the plural version of the title. | |||
*/ | |||
public static function getEntityTitle($plural = FALSE) { | |||
return $plural ? E::ts('Quotations') : E::ts('Quotation'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's revert this line @erawat
erawat
force-pushed
the
BTHAB-185-display-statuses
branch
from
September 21, 2023 13:35
0e20b36
to
6386152
Compare
Include regenerating boilerplate code
The service calculates statuses and amounts from the given sales order ID
erawat
force-pushed
the
BTHAB-185-display-statuses
branch
from
September 21, 2023 13:37
6386152
to
439822b
Compare
olayiwola-compucorp
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request:
Before
Didn't exist.
After
Invoice and payment statuses are changed based on contributions and payments
Payment status and invoices status have been added to the quotation list screen.
Technical Details
In this pull request, I migrated the Civix files from version 22.05.2 to 23.02.1 in order to regenerate the boilerplate DAO files for the new entities. As a result, I had to make changes in the upgrader files
In this commit c1492df, I removed the Step20 upgrader and added its logic to the Step19 upgrader since the extension has not been released. Therefore, we only need one upgrader
The payment and invoicing statuses will be calculated based on the statuses of contributions and payments linked to the quotation. These calculations are performed and updated in the CaseSalesOrder entity when:
Comments
There is a slight issue with the styling of the total invoicing and total paid amount rows, which will be addressed in the next pull request.