CIVIPLMMSR-399: Fix Case Categry Type Selection #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olayiwola-compucorp
approved these changes
Dec 20, 2024
shahrukh-compuco
deleted the
civiplmmsr-399-fix-case-type-category-seelction
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pr moves the settings for civicase-base angular file from settings array to setting factory class which fixes the issue that was resulting in invalid case type category selection on cases, awards or prospects dashboard.
Before
##After
Technical Details
This was being caused due to the fact that the settings that are provided as array are cached on first page load so if user opened the cases dashboard first after a cache clear and then navigates to awards it will still hve case type category selected as cases in the cache. Whereas settings factory is called on each page reload.