BTHAMM-31: Set sales order line items from backend #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olayiwola-compucorp
force-pushed
the
BTHAMM-31-correct-qot
branch
from
f553bbd to
1edecbf
Compare
shahrukh-compuco
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR set the sales order line items from the backend using PHP, instead of the frontend which was causing issues with the total amount displaying incorrect values.
Previously:
We pass the user-supplied percentage to the frontend JavaScript and perform the necessary computations there. However, this approach is causing conflicts with other extensions, such as finance-extras (due to changes in the contribution form) and lineitemedit, which also modify line items.
In this PR:
We perform all percentage computations on the backend and prepopulate the form items using the altercontent hook.
Before
The total amount value resets to zero when the financial type or any value changes on the form.
After
The total amount always display the correct value
