Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMCL-644: Fix contribution settings page #1021

Merged

Conversation

shahrukh-compuco
Copy link

Overview

This pr fixes an issue that occurs due to upgrade to civicrm version 5.75.0 because of some structural changes to civicrm core form class and it restricted the user from accessing civi contribute settings page.

Before

COMCL-644

After

Screenshot 2024-07-25 at 5 18 57 PM

@shahrukh-compuco shahrukh-compuco requested a review from erawat July 25, 2024 12:30
@shahrukh-compuco shahrukh-compuco merged commit fd53403 into 4.2.0-dev Jul 25, 2024
2 checks passed
@shahrukh-compuco shahrukh-compuco deleted the COMCL-644-fix-contribution-settings-page branch July 25, 2024 12:35
@eileenmcnaughton
Copy link

Hmm - FWIW you can add settings to the form by defining a key on the setting 'settings_pages' => ['contribute' => ['weight' => 30]], without having an override like this - but it won't put it in the 'invoice' section of the settings - - I kinda feel it should be split into 2 pages upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants