BTHAMM-15: Add custom delay before updating line item total #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahrukh-compuco
previously approved these changes
May 15, 2024
olayiwola-compucorp
force-pushed
the
BTHAMM-15-delay-total-calc
branch
from
6e9bd9e to
e10157d
Compare
shahrukh-compuco
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In this PR we have added a small delay between when the contribution page loads and when the quotation line items are populated, this is necessary because the quotation line items can be cleared by other extensions like Financeextras or lineitemedit that initializes the line item with default values.
The Quotation items
Creating 100% contribution:
Before
Occasionally the contribution line item total shows as ZERO or incorrect values.
After
The contribution line item total shows the correct values.
