Merge pull request #981 from compucorp/CIWEMB-514-fix-contribcreate

CIWEMB-514: Fix not able to create non-salesorder contribution
compucorp · Oct 2, 2023 · 460c3e8 · 460c3e8
2 parents b8be601 + 56aec87
commit 460c3e8
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/CRM/Civicase/Hook/Post/CaseSalesOrderPayment.php b/CRM/Civicase/Hook/Post/CaseSalesOrderPayment.php
@@ -41,8 +41,8 @@ public function run($op, $objectName, $objectId, &$objectRef) {
       ->execute()
       ->first();
 
-    $this->updateQuotationFinancialStatuses($contribution['Opportunity_Details.Quotation']);
-    $this->updateCaseOpportunityFinancialDetails($contribution['Opportunity_Details.Case_Opportunity']);
+    $this->updateQuotationFinancialStatuses($contribution['Opportunity_Details.Quotation'] ?: NULL);
+    $this->updateCaseOpportunityFinancialDetails($contribution['Opportunity_Details.Case_Opportunity'] ?: NULL);
   }
 
   /**
@@ -51,7 +51,7 @@ public function run($op, $objectName, $objectId, &$objectRef) {
    * @param int $salesOrderID
    *   CaseSalesOrder ID.
    */
-  private function updateQuotationFinancialStatuses(int $salesOrderID): void {
+  private function updateQuotationFinancialStatuses(?int $salesOrderID): void {
     if (empty($salesOrderID)) {
       return;
     }