BIID-97: Fix pending upgrade after installed the extension. #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erawat
changed the title
olayiwola-compucorp
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request addresses the issue encountered during the initial installation of the extension when CiviCRM continues to throw an error due to pending upgrades for the extension. The problem has been resolved with this pull request.
The reason for CiviCRM displaying a pending upgrade for the extension is that the certificate extension overrides the onPostInstall method to set up certificate entities but lacks the logic to establish the current revision. To address this, I refactored the
onPostInstallmethod intopostInstall,ensuring it is called from the base class after setting the current revision. The modifications made during this process can be reviewed in this commit.Additionally, this pull request upgrades Civix from version 22.05.2 to version 23.02.1, which is included in CompuContainer. This update is crucial for future compatibility with newer versions of Civi. The upgrade was executed automatically using the civix upgrade command.