generated from compucorp/template-repo
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MMB-284: Handle Multiple Current Memberships #83
Merged
shahrukh-compuco
merged 5 commits into
MMB-78-workstream
from
MMB-284-multiple-current-memberships
Dec 5, 2023
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
2ad7abb
MMB-271: Add certificate validity date tokens
shahrukh-moby 00c5c68
Merge branch 'MMB-78-workstream' into MMB-271-add-min-max-date-tokens
shahrukh-moby 6620a27
MMB-271: Refactor code to use status name instead of status id
shahrukh-moby 1c57150
MMB-273: Add renewal or rolling start date token
shahrukh-moby 66dea7d
MMB-284: Handle multiple active memberships for a contact
shahrukh-moby File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @shahrukh-compuco Given that these new tokens are related to the membership entity, I believe they are better moved to and resolved in the membership token class https://github.com/compucorp/uk.co.compucorp.certificate/blob/master/CRM/Certificate/Token/Membership.php
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Ola
As discussed that there might be a new ticket from Pallavi to transfer all the work to membership type only, I think then not only this but other work in this workstream will be transffered at once to the membership classes