PCHR-4396: Fix for the new response format of HRJobContract.getCurren…

…tContract That API now returns an array instead of an object
compucorp · Nov 13, 2018 · a3fdbab · a3fdbab
1 parent 8f955f7
commit a3fdbab
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/civihr_employee_portal/src/View/MyDetailsView.php b/civihr_employee_portal/src/View/MyDetailsView.php
@@ -51,15 +51,12 @@ private function getCurrentRevision($contactID) {
       'contact_id' => $contactID,
     ]);
 
-    // God knows why but this result is a stdClass
-    if (!isset($contract['values']->contract_id)) {
+    if (empty($contract['values']['contract_id'])) {
       return NULL;
     }
 
-    $contractID = $contract['values']->contract_id;
-
     return civicrm_api3('HRJobContractRevision', 'getcurrentrevision', [
-      'jobcontract_id' => $contractID,
+      'jobcontract_id' => $contract['values']['contract_id'],
     ])['values'];
   }