CS5.1 - Disallow callbacks at the start of a script's callback function #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevincheng96
added a commit
to compound-finance/quark-scripts
that referenced
this pull request
Oct 22, 2024
…on (#92) Brings over the exact same [fixes](compound-finance/quark#229) to the same files from the `quark` repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR establishes the pattern that Quark scripts using callbacks should disallow callbacks at the start of their callback function. Otherwise, any external contract that is called in the same Quark Operation context can call back into the Quark wallet and potentially execute malicious code in the context of the wallet.