CS6.7 - Remove unreachable code #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluffywaffles
approved these changes
Oct 15, 2024
hayesgm
reviewed
Oct 15, 2024
| @@ -156,10 +156,6 @@ abstract contract QuarkScript { | |||
| bytes32 submissionToken = getActiveSubmissionToken(); | |||
| uint256 n; | |||
|
|
|||
| if (submissionToken == QuarkNonceManagerMetadata.EXHAUSTED) { | |||
There was a problem hiding this comment.
See above line 151:
Note: this may not be accurate after any nested calls from a script
Is that statement still accurate?
There was a problem hiding this comment.
Correct, this statement no longer holds. I actually removed this comment in another PR yesterday. See: 5e24a38#diff-a219685a8ac1b6d53f4feb7ad9ab76351cf5f4dd68a30022fc18a4a9ad65467fL151
Yeah. The submission token can never be |
kevincheng96
force-pushed
the
kevin/cs-6.7
branch
from
b77d061 to
132213e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From ChainSecurity audit: "The submissionToken will never be equal to EXHAUSTED in this context, as this is the value provided by the user of the wallet and submitted to the nonce manager, which asserts that it is different from EXHAUSTED."
This appears to be true, so we can remove this check.