TStore for Transients #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch bumps us up to 0.8.27 and cancun and starts using `tstore` and `tload` for transient reads and writes. Note: we still clear values mostly to ensure that post-nested calls the script will see 0 instead of the nested's own value. Note: I have not taken a stab at understanding `ALLOW_CALLBACKS` and how that should function. Patches: * Try to build allow callbacks to ensure it still works as expected, though it can't be observed now.
hayesgm
force-pushed
the
hayesgm/tstore
branch
from
9b63e07 to
c2aaa37
Compare
kevincheng96
approved these changes
Sep 12, 2024
| @@ -482,31 +482,28 @@ contract QuarkWallet is IERC1271 { | |||
| assembly { | |||
| // TODO: TSTORE the callback slot to 0 | |||
There was a problem hiding this comment.
We can address this TODO by also setting the callback slot to 0 after the callcode.
There was a problem hiding this comment.
Curious if there's a big benefit here, since tstore will clear naturally? I guess all of these clears are mostly in the camp of "if you do nesting, you're 8% safer"?
src/quark-core-scripts/src/vendor/uniswap_v3_periphery/PoolAddress.sol
Outdated
Show resolved
Hide resolved
This patch simply adds a cancel core script that can be used (a) as a nop to cancel a chain, or (b) to directly call `nonceManager.cancel(nonce)` with one or more nonces. These are merely given as helpers for the end-users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch bumps us up to 0.8.27 and cancun and starts using
tstoreandtloadfor transient reads and writes. Note: we still clear values mostly to ensure that post-nested calls the script will see 0 instead of the nested's own value.Note: I have not taken a stab at understanding
ALLOW_CALLBACKSand how that should function.