Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GAS_OVERHEAD to include the 21k base gas + calldata costs #200

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Update GAS_OVERHEAD to include the 21k base gas + calldata costs #200

merged 1 commit into from
Jun 4, 2024

Conversation

kevincheng96
Copy link
Collaborator

No description provided.

@cwang25 cwang25 self-requested a review June 4, 2024 17:36
cwang25
cwang25 approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@cwang25 cwang25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Also on the other side, I think we better to overcharge user a little bit than undercharge (cuz that's a chance of getting grief and losing money). User pay a little more for a convenience is understandable haha.

hayesgm
hayesgm approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@hayesgm hayesgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬

Base automatically changed from kevin/remove-swallow-reverts to main June 4, 2024 19:54
@kevincheng96 kevincheng96 merged commit c7a8ff5 into main Jun 4, 2024
4 checks passed
@kevincheng96 kevincheng96 deleted the kevin/gas-overhead branch June 4, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwang25 cwang25 cwang25 approved these changes

@hayesgm hayesgm hayesgm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevincheng96 @hayesgm @cwang25